Skip to content

visionOS#1333

Merged
RomanPodymov merged 32 commits into
mxcl:masterfrom
RomanPodymov:feature/visionos
Apr 6, 2024
Merged

visionOS#1333
RomanPodymov merged 32 commits into
mxcl:masterfrom
RomanPodymov:feature/visionos

Conversation

@RomanPodymov

@RomanPodymov RomanPodymov commented Feb 13, 2024

Copy link
Copy Markdown
Collaborator

Hello.
Thank you for PromiseKit.
visionOS support.
Fix #1326.

@RomanPodymov RomanPodymov requested a review from mxcl February 13, 2024 05:36
@RomanPodymov RomanPodymov marked this pull request as draft February 13, 2024 05:36
@mxcl

mxcl commented Feb 14, 2024

Copy link
Copy Markdown
Owner

Nice job. Approved. We should drop Carthage officially probs. Does anyone use it?

@mxcl

mxcl commented Feb 14, 2024

Copy link
Copy Markdown
Owner

Undraft it when ready

@RomanPodymov

Copy link
Copy Markdown
Collaborator Author

Hello @mxcl
Probably someone is still using PromiseKit + Carthage since PromiseKit is an old and popular library. But we can at least disable Carthage CI for now.

@RomanPodymov RomanPodymov marked this pull request as ready for review February 15, 2024 12:37
@RomanPodymov

Copy link
Copy Markdown
Collaborator Author

Hello @mxcl
It's ready for review.

@RomanPodymov RomanPodymov merged commit a3b4668 into mxcl:master Apr 6, 2024
@RomanPodymov RomanPodymov deleted the feature/visionos branch April 6, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support of visionOS

2 participants